Merge gvamotiondetect into gstvideoanalytics library #511
Conversation
mholowni
requested review from
BaoHuiling,
OskarFiedot,
ZiningLi,
dmichalo,
jmotow,
marcin-wadolkowski,
msmiatac,
nszczygl9,
oonyshch,
pbartosik,
qianlongding,
tbujewsk,
walidbarakat,
yangjianfeng1208 and
yunowo
as code owners
There was a problem hiding this comment.
Pull request overview
This PR consolidates the gvamotiondetect GStreamer element into the main gstvideoanalytics library, eliminating the need for a separate shared library (.so/.dll file). The changes involve removing the standalone CMake build configuration for gvamotiondetect and integrating its source files, dependencies, and registration logic directly into the gstvideoanalytics library build system.
Key changes:
- Removed standalone plugin initialization code from gvamotiondetect source files
- Integrated gvamotiondetect registration into the central plugin registrator
- Consolidated build configuration by removing separate CMakeLists.txt and merging dependencies into the main elements build
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/monolithic/gst/registrator/register_elements.cpp | Added gvamotiondetect header include and element registration call |
| src/monolithic/gst/registrator/CMakeLists.txt | Added gvamotiondetect directory to include paths |
| src/monolithic/gst/elements/gvamotiondetect/gvamotiondetect_win.cpp | Removed duplicate copyright header, removed standalone plugin registration code, updated copyright year |
| src/monolithic/gst/elements/gvamotiondetect/gvamotiondetect.cpp | Added [[maybe_unused]] attributes to suppress warnings, removed standalone plugin registration code, updated copyright year |
| src/monolithic/gst/elements/gvamotiondetect/CMakeLists.txt | Deleted entire standalone CMake build configuration |
| src/monolithic/gst/elements/CMakeLists.txt | Added gvamotiondetect source files, headers, include directories, and dependencies to main elements build |
| docker/fedora41/fedora41.Dockerfile | Added ocl-icd-devel package dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Fix fedora docker build * more fixes
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Merged gvamotiondetect into gstvideoanalytics library to reduce number of .so/.dll files
Any Newly Introduced Dependencies
N/A
How Has This Been Tested?
Build was tested and it was verified that gvamotiondetect element is present.
Checklist: